feat: Add custom_attributes field to OrganizationMembership#82
Open
ajworkos wants to merge 4 commits into
Open
feat: Add custom_attributes field to OrganizationMembership#82ajworkos wants to merge 4 commits into
ajworkos wants to merge 4 commits into
Conversation
- Add idp_attributes: map() to type spec
- Add :idp_attributes to defstruct
- Add idp_attributes: map["idp_attributes"] || %{} to cast/1 with default empty map
- CI will run tests (local testing was not possible due to dependency issues)
This change adds support for IDP custom attributes on organization
memberships, which are sourced from the identity provider and stored
as customAttributes in the API.
Related to workos/workos PR #50470
Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Greptile SummaryThis PR adds
Confidence Score: 5/5The change is narrowly scoped to exposing a new organization membership field and includes corresponding fixture/test updates. The implementation appears straightforward, with no review comments left open from the code changes.
 T-Rex LogsWhat T-Rex did
Reviews (2): Last reviewed commit: "Add custom_attributes to organization me..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
ajworkos
changed the title
Contributor
|
@ajworkos is this still something you'd like to see shipped? if so do you mind merging |
devin-ai-integration
Bot
changed the title
Author
|
Done @gjtorikian! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
custom_attributesfield toOrganizationMembershipmodel to expose custom attributes from identity providers.Changes
custom_attributesfield to OrganizationMembership type/model{}API Field Details
The field will be present in:
JSON field name:
custom_attributes(snake_case)